Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate Camera to new arch #3090

Merged
merged 7 commits into from
Oct 2, 2023
Merged

feat: migrate Camera to new arch #3090

merged 7 commits into from
Oct 2, 2023

Conversation

WoLewicki
Copy link
Contributor

@WoLewicki WoLewicki commented Oct 2, 2023

PR adding New Architecture support to the library 🎉

We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:

or you just want to ask any questions, hit us up on [email protected]


Notes

PR adding Camera implementation on new arch and adding all the files to fabricexample so it is easier to test new things there.

@WoLewicki
Copy link
Contributor Author

Ok @mfazekas it looks green 🚀

@mfazekas mfazekas merged commit eb65304 into main Oct 2, 2023
18 checks passed
@mfazekas mfazekas deleted the @wolewicki/migrate-camera branch October 2, 2023 12:32
@mfazekas
Copy link
Contributor

mfazekas commented Oct 2, 2023

@WoLewicki I've just pressed the merge, but you're still not on contributors graph. We can revert and maybe if you press it you'll be.

¯\_(ツ)_/¯

Nevermind you're in the graph:

image

@WoLewicki
Copy link
Contributor Author

Hah, nice. Yeah, now I am the author of the commit so all is fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants