Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix applying of bool properties for MapView component on iOS with New Arch enabled #3730

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TuTejsy
Copy link

@TuTejsy TuTejsy commented Dec 20, 2024

Description

Fix applying of boolean properties: attributionEnabled, logoEnabled, compassEnabled, compassFadeWhenNorth, zoomEnabled, rotateEnabled, pitchEnabled to MapView component on iOS with New Architecture enabled.

The bug has been caused by a boolean type casting mistake in RNMBXMapViewComponentView.mm class.
All boolean props were casting to id type that always cast to true when passing to Swift RNMBXMapView class.

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Screenshot 2024-12-20 at 13 07 19
repro-480.mov

Component to reproduce the issue you're fixing

    <MapView
          ref={(c) => (this._map = c)}
          onPress={this.onPress}
          style={styles.mapView}
          attributionEnabled={false}
          logoEnabled={false}
          scaleBarEnabled={false}
          zoomEnabled={false}
          rotateEnabled={false}
          pitchEnabled={false}
        >
             <Camera zoomLevel={9} centerCoordinate={[-73.970895, 40.723279]} />
    </MapView>

@TuTejsy TuTejsy requested a deployment to CI with Mapbox Tokens December 20, 2024 09:11 — with GitHub Actions Waiting
@TuTejsy TuTejsy requested a deployment to CI with Mapbox Tokens December 20, 2024 09:11 — with GitHub Actions Waiting
@TuTejsy TuTejsy requested a deployment to CI with Mapbox Tokens December 20, 2024 09:11 — with GitHub Actions Waiting
@TuTejsy TuTejsy requested a deployment to CI with Mapbox Tokens December 20, 2024 09:11 — with GitHub Actions Waiting
@TuTejsy TuTejsy requested a deployment to CI with Mapbox Tokens December 20, 2024 09:11 — with GitHub Actions Waiting
@TuTejsy TuTejsy requested a deployment to CI with Mapbox Tokens December 20, 2024 09:11 — with GitHub Actions Waiting
@TuTejsy TuTejsy requested a deployment to CI with Mapbox Tokens December 20, 2024 09:11 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant