Fix applying of bool properties for MapView component on iOS with New Arch enabled #3730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix applying of boolean properties:
attributionEnabled, logoEnabled, compassEnabled, compassFadeWhenNorth, zoomEnabled, rotateEnabled, pitchEnabled
to MapView component on iOS with New Architecture enabled.The bug has been caused by a boolean type casting mistake in RNMBXMapViewComponentView.mm class.
All boolean props were casting to
id
type that always cast totrue
when passing to Swift RNMBXMapView class.Checklist
CONTRIBUTING.md
yarn generate
in the root folder/example
app./example
)Screenshot OR Video
repro-480.mov
Component to reproduce the issue you're fixing