CID 1565414, 1565415: COPY_INSTEAD_OF_MOVE

rnpgp · Nov 24, 2024 · 42f206c · 42f206c
1 parent 3bd1b71
commit 42f206c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/lib/rnp.cpp b/src/lib/rnp.cpp
@@ -4434,7 +4434,7 @@ parse_preferences(json_object *jso, rnp::UserPrefs &prefs)
     /* Preferred key server */
     std::string key_server;
     if (json_get_str(jso, "key server", key_server)) {
-        prefs.key_server = key_server;
+        prefs.key_server = std::move(key_server);
     }
     /* Do not allow extra unknown keys */
     return !json_object_object_length(jso);
@@ -4571,7 +4571,7 @@ parse_keygen_primary(rnp_ffi_t                    ffi,
         if (str.size() > MAX_ID_LENGTH) {
             return nullptr;
         }
-        cert.userid = str;
+        cert.userid = std::move(str);
     }
     /* Preferences */
     auto obj = json_get_obj(jso, "preferences");