Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements basic support for V5 keys and signatures. #1093

Closed
wants to merge 1 commit into from

Conversation

joke325
Copy link
Contributor

@joke325 joke325 commented Apr 2, 2020

Closes #821, #820, #26

@joke325 joke325 force-pushed the joke325-issue821 branch from 78a66a2 to 6914eda Compare April 2, 2020 19:59
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #1093 into master will decrease coverage by 0.04%.
The diff coverage is 72.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
- Coverage   83.22%   83.18%   -0.05%     
==========================================
  Files          76       76              
  Lines       29231    29313      +82     
==========================================
+ Hits        24328    24383      +55     
- Misses       4903     4930      +27     
Impacted Files Coverage Δ
src/librepgp/stream-key.cpp 66.78% <ø> (ø)
src/librepgp/stream-dump.cpp 74.75% <33.33%> (ø)
src/lib/crypto/signatures.cpp 65.74% <62.50%> (-1.25%) ⬇️
src/librepgp/stream-packet.cpp 76.25% <66.17%> (-0.97%) ⬇️
src/lib/fingerprint.cpp 69.38% <70.00%> (-0.62%) ⬇️
src/librepgp/stream-sig.cpp 65.63% <81.81%> (+<0.01%) ⬆️
src/lib/rnp.cpp 76.16% <100.00%> (+<0.01%) ⬆️
src/librekey/key_store_kbx.cpp 72.41% <100.00%> (+0.14%) ⬆️
src/tests/streams.cpp 98.84% <100.00%> (+0.01%) ⬆️
src/librepgp/stream-write.cpp 79.03% <0.00%> (+0.10%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a79e06...cc0b4ad. Read the comment docs.

@joke325 joke325 force-pushed the joke325-issue821 branch 8 times, most recently from 4c4bc5a to 5c8e5d6 Compare April 3, 2020 21:15
@joke325 joke325 force-pushed the joke325-issue821 branch 3 times, most recently from 8c664d7 to f328025 Compare April 28, 2020 10:26
@ronaldtse
Copy link
Contributor

@joke325 is this ready to go?

@joke325
Copy link
Contributor Author

joke325 commented Apr 30, 2020

@ronaldtse it's waiting for review

@ni4
Copy link
Contributor

ni4 commented Apr 30, 2020

@ronaldtse @joke325 I would prefer to wait till the end of May (when we'll do a release for TB team) before merging in such major changes. Also it must be heavily covered with tests, checking all operations, key import/exports/generation, and so on.

@ni4
Copy link
Contributor

ni4 commented Dec 11, 2023

Closing this as v5 support was merged via PR #2111

@ni4 ni4 closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement basic support for reading V5 keys
3 participants