Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage for KBX and G10 #2080

Merged
merged 2 commits into from
Jun 4, 2023
Merged

Conversation

antonsviridenko
Copy link
Contributor

and fix some parsing issues. Closes #1997

@antonsviridenko antonsviridenko marked this pull request as draft May 21, 2023 16:50
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 89.64% and project coverage change: +0.33 🎉

Comparison is base (f0ede7e) 83.48% compared to head (58bfe0f) 83.82%.

❗ Current head 58bfe0f differs from pull request most recent head b51b419. Consider uploading reports for the commit b51b419 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2080      +/-   ##
==========================================
+ Coverage   83.48%   83.82%   +0.33%     
==========================================
  Files         159      161       +2     
  Lines       31957    32391     +434     
==========================================
+ Hits        26679    27151     +472     
+ Misses       5278     5240      -38     
Impacted Files Coverage Δ
src/lib/crypto/ecdh.cpp 80.57% <ø> (ø)
src/lib/crypto/ecdh_ossl.cpp 69.03% <ø> (ø)
src/lib/crypto/mem.h 71.42% <ø> (ø)
src/lib/crypto/dl_ossl.cpp 67.20% <70.00%> (-3.00%) ⬇️
src/librepgp/stream-dump.cpp 79.02% <74.28%> (+0.61%) ⬆️
src/lib/crypto/ec_ossl.cpp 72.72% <76.27%> (+1.89%) ⬆️
src/lib/crypto/dsa_ossl.cpp 66.96% <77.41%> (-1.54%) ⬇️
src/lib/crypto/elgamal_ossl.cpp 67.68% <78.57%> (+0.34%) ⬆️
src/lib/crypto/rsa_ossl.cpp 68.31% <79.81%> (+1.30%) ⬆️
src/librekey/key_store_kbx.cpp 81.89% <80.00%> (+11.84%) ⬆️
... and 13 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@antonsviridenko antonsviridenko force-pushed the antonsviridenko-1997-kbx-g10-tests branch 2 times, most recently from a862d4d to e31e297 Compare June 4, 2023 06:30
@antonsviridenko antonsviridenko force-pushed the antonsviridenko-1997-kbx-g10-tests branch from e31e297 to b51b419 Compare June 4, 2023 06:34
@antonsviridenko antonsviridenko marked this pull request as ready for review June 4, 2023 08:12
@antonsviridenko antonsviridenko requested review from ni4 and ronaldtse June 4, 2023 08:13
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ronaldtse
Copy link
Contributor

Thank you @antonsviridenko and @ni4 !

@ronaldtse ronaldtse merged commit 12133aa into main Jun 4, 2023
@ronaldtse ronaldtse deleted the antonsviridenko-1997-kbx-g10-tests branch June 4, 2023 08:56
@antonsviridenko
Copy link
Contributor Author

what tasks can I do next?

@ni4
Copy link
Contributor

ni4 commented Jun 5, 2023

@antonsviridenko #2083 , #1980, #1786, #1643, #1611, #1609/#1857 or any other one you'd find appropriate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend tests coverage on KBX/G10
3 participants