Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed tests against gpg 2.3.0 beta #2127

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Sep 15, 2023

One of gnupg tags used for testing pints to 2.3.0 beta version of 2021.
I do not think there is any value to test against it -- 2.3 line is at 2.3.8 know.

@maxirmx maxirmx force-pushed the maxirmx-remove-old-beta-test branch from dfcc109 to 76a58a8 Compare September 15, 2023 09:41
@maxirmx maxirmx changed the title Removed tests against gpg 2.3.0 beta (as of 2021) Removed tests against gpg 2.3.0 beta Sep 15, 2023
@maxirmx maxirmx force-pushed the maxirmx-remove-old-beta-test branch from 76a58a8 to 4193aa0 Compare September 15, 2023 10:14
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (22f5b19) 83.89% compared to head (7140ea9) 83.90%.
Report is 1 commits behind head on main.

❗ Current head 7140ea9 differs from pull request most recent head 4193aa0. Consider uploading reports for the commit 4193aa0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2127      +/-   ##
==========================================
+ Coverage   83.89%   83.90%   +0.01%     
==========================================
  Files         161      161              
  Lines       32249    32249              
==========================================
+ Hits        27054    27059       +5     
+ Misses       5195     5190       -5     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxirmx maxirmx marked this pull request as ready for review September 15, 2023 21:11
@maxirmx maxirmx requested review from ni4 and ronaldtse September 15, 2023 21:11
@ronaldtse
Copy link
Contributor

Two questions:

  1. It looks like we still test against 2.3.1 instead of 2.3.8. Is there a reason for that?
  2. Should we retain the beta tag for GnuPG so that we can test against the latest beta?

@maxirmx
Copy link
Member Author

maxirmx commented Sep 16, 2023

My understanding of https://www.gnupg.org/download/index.html
"Long-time support" : 2.1.x --> 2.2.x The last tag in git is 2.2.41
"Current line": 2.3.x --> 2.4.x The last tag in git is 2.4.3

There were no "beta" tags since 2021. We can probable test against HEAD of master branch
There is a related issue that calls for different approach: #1998

I suggest that we

  • run tests for system-shipped version of gnupg for all platforms (now Centos and Fedora run against a version from the stable line and Centos8 runs against a version from LTS line , 2.3.1, and the beta under discussion
  • run tests against LTS (2.2.41) and stable (2.4.3) in some newer environment like Fedora 3.6
  • do not run against unreleased versions unsless we want to support unreleased features

@ni4
Copy link
Contributor

ni4 commented Sep 16, 2023

@maxirmx Agree with you. We added tests against beta when were developing AEAD support. Now we don't need that, so may test only against LTS & shipped versions, unless something new arrives. It would be also good to have Dockerfile which would build latest HEAD of GnuPG to allow local testing/debugging, but this is not of high priority at the moment.

Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maxirmx !

@ronaldtse ronaldtse merged commit 8fac3f6 into main Sep 16, 2023
109 checks passed
@ronaldtse ronaldtse deleted the maxirmx-remove-old-beta-test branch September 16, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants