-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed tests against gpg 2.3.0 beta #2127
Conversation
dfcc109
to
76a58a8
Compare
76a58a8
to
4193aa0
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2127 +/- ##
==========================================
+ Coverage 83.89% 83.90% +0.01%
==========================================
Files 161 161
Lines 32249 32249
==========================================
+ Hits 27054 27059 +5
+ Misses 5195 5190 -5 ☔ View full report in Codecov by Sentry. |
Two questions:
|
My understanding of https://www.gnupg.org/download/index.html There were no "beta" tags since 2021. We can probable test against HEAD of master branch I suggest that we
|
@maxirmx Agree with you. We added tests against beta when were developing AEAD support. Now we don't need that, so may test only against LTS & shipped versions, unless something new arrives. It would be also good to have Dockerfile which would build latest HEAD of GnuPG to allow local testing/debugging, but this is not of high priority at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @maxirmx !
One of gnupg tags used for testing pints to 2.3.0 beta version of 2021.
I do not think there is any value to test against it -- 2.3 line is at 2.3.8 know.