Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new centos & fedora workflow based on pre-built containers #2130

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Sep 21, 2023

  1. As propsed at Refactor CI workflows to use GitHub Actions capabilities #1968 (comment). Reduces CI script complexity and improves timing significantly (Improve CI build and test speeds #1571)
  2. Uses system-shipped json-c when possible. Uses system-shipped gnugp and botan or provides an option to easily do so (CI: Use system-shipped Json-C/Botan/GnuPG when applicable. #1908)
  3. Added an option to run tests agains head(botan, gnugp)
  4. Added code coverage for botan 3.x

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -6.93% ⚠️

Comparison is base (8fac3f6) 83.89% compared to head (ec1adc1) 76.97%.

❗ Current head ec1adc1 differs from pull request most recent head 2e56e27. Consider uploading reports for the commit 2e56e27 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2130      +/-   ##
==========================================
- Coverage   83.89%   76.97%   -6.93%     
==========================================
  Files         161      193      +32     
  Lines       32249    36879    +4630     
==========================================
+ Hits        27054    28386    +1332     
- Misses       5195     8493    +3298     

see 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxirmx maxirmx linked an issue Sep 21, 2023 that may be closed by this pull request
@maxirmx maxirmx marked this pull request as ready for review September 21, 2023 17:53
@maxirmx maxirmx requested review from ronaldtse and ni4 September 21, 2023 17:55
@maxirmx maxirmx linked an issue Sep 21, 2023 that may be closed by this pull request
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maxirmx !

@ronaldtse ronaldtse merged commit 6eb6c59 into main Sep 22, 2023
111 checks passed
@maxirmx maxirmx deleted the maxirmx-refactor-centos branch November 16, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants