MSVC sanitizer build

[maxirmx]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d934fa9) 76.98% compared to head (b21b5ea) 76.97%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2151      +/-   ##
==========================================
- Coverage   76.98%   76.97%   -0.02%     
==========================================
  Files         194      194              
  Lines       37074    37074              
==========================================
- Hits        28542    28536       -6     
- Misses       8532     8538       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maxirmx]

Created Windows runner with ASAN enbled; fixed memory corruption as described in #2152 and some annoying warning.
I was not able to run cli_test in native environment -- #2149, #2150

[maxirmx]

Regarding previously added FALLTHROUGH_STATEMENT (f7ff817)

It was defined as

# define FALLTHROUGH_STATEMENT [[fallthrough]];

and applied as

FALLTHROUGH_STATEMENT;

That was not correct. The standart calls for single null statement, for two some compilers generate a hundred of warnings.

[ni4]

@maxirmx Thanks, will check it out. Probably we should wait till the windows-native issue is resolved, I was able to reproduce it with pure botan calls.

[ni4]

@maxirmx it got resolved (but not released yet) and it isn't our issue: randombit/botan#3812
Actually it was a great luck to catch it!

[ni4]

@maxirmx Could you please rebase on main, as PR #2148 is merged? Or I can do that as well.

[maxirmx]

@maxirmx Could you please rebase on main, as PR #2148 is merged? Or I can do that as well.

@ni4 I have rebased it

[ni4]

LGTM, thanks!

[ni4]

Just in case: coverage fails since one of the previous tests hit some ElGamal 'rarely-hit' code path, and now it didn't.

[ronaldtse]

Thank you @maxirmx @ni4 !