Fix armored stream detection and refactor pgp_source_t. #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ni4
force-pushed
the
ni4-2154-fix-armored-stream-detection
branch
from
59531c4 to
3f8efcc
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2155 +/- ##
==========================================
+ Coverage 76.94% 76.97% +0.02%
==========================================
Files 194 194
Lines 37082 37074 -8
==========================================
+ Hits 28533 28536 +3
+ Misses 8549 8538 -11 ☔ View full report in Codecov by Sentry. |
…ods instead of functions.
ni4
force-pushed
the
ni4-2154-fix-armored-stream-detection
branch
from
6d8e3fe to
5e2af25
Compare
antonsviridenko
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect detection of cleartext-signed stream. In addition it refactors pgp_source_t to be more C++ (still a lot of work left).
Fixes #2154