Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security override for sha1 #2244

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Conversation

desvxx
Copy link
Contributor

@desvxx desvxx commented Jun 9, 2024

fixes #2181

@desvxx desvxx requested a review from ni4 June 9, 2024 00:23
@ni4
Copy link
Contributor

ni4 commented Jun 24, 2024

@desvxx Could you please rebase this on main, as PR with CI fixes is already merged? Thanks!

@desvxx desvxx force-pushed the desvxx-2181-add-cli-parameter branch from 207ce71 to d5b3753 Compare June 25, 2024 21:32
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (45e3392) to head (d70c7d4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2244   +/-   ##
=======================================
  Coverage   83.77%   83.78%           
=======================================
  Files         113      113           
  Lines       23203    23215   +12     
=======================================
+ Hits        19439    19450   +11     
- Misses       3764     3765    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just few minor updates.

src/tests/cli_tests.py Show resolved Hide resolved
src/rnpkeys/rnpkeys.cpp Show resolved Hide resolved
@desvxx desvxx force-pushed the desvxx-2181-add-cli-parameter branch from d5b3753 to d70c7d4 Compare August 25, 2024 18:34
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@desvxx desvxx requested a review from maxirmx September 16, 2024 21:08
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@desvxx desvxx merged commit 112fcf4 into rnpgp:main Sep 17, 2024
125 checks passed
@desvxx desvxx deleted the desvxx-2181-add-cli-parameter branch October 13, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLI parameter --allow-sha1-key-sigs
3 participants