Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate implementations of some DSA/ECDSA functions #2269

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Remove duplicate implementations of some DSA/ECDSA functions #2269

merged 1 commit into from
Sep 19, 2024

Conversation

desvxx
Copy link
Contributor

@desvxx desvxx commented Sep 8, 2024

fixes #2248

@desvxx desvxx force-pushed the desvxx-2248-remove-duplicates branch 3 times, most recently from 5af6182 to faaa776 Compare September 8, 2024 15:25
@codecov Codecov
Copy link

codecov bot commented Sep 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.00%. Comparing base (abec6c7) to head (3d1327e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/crypto/dsa_common.cpp 89.47% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2269      +/-   ##
==========================================
- Coverage   84.01%   84.00%   -0.01%     
==========================================
  Files         113      114       +1     
  Lines       23069    23050      -19     
==========================================
- Hits        19381    19364      -17     
+ Misses       3688     3686       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desvxx desvxx force-pushed the desvxx-2248-remove-duplicates branch from faaa776 to 3d1327e Compare September 16, 2024 21:18
ni4
ni4 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ni4 ni4 requested a review from maxirmx September 18, 2024 09:26
maxirmx
maxirmx approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxirmx maxirmx merged commit 47fee37 into rnpgp:main Sep 19, 2024
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ni4 ni4 ni4 approved these changes

@maxirmx maxirmx maxirmx approved these changes

@ronaldtse ronaldtse Awaiting requested review from ronaldtse

@antonsviridenko antonsviridenko Awaiting requested review from antonsviridenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicate implementations of some DSA/ECDSA functions.
3 participants
@desvxx @maxirmx @ni4