Refactor signature subpackets for better code and update FFI. #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2281 +/- ##
==========================================
+ Coverage 84.27% 84.65% +0.38%
==========================================
Files 114 116 +2
Lines 23324 23422 +98
==========================================
+ Hits 19656 19829 +173
+ Misses 3668 3593 -75 ☔ View full report in Codecov by Sentry. |
ni4
force-pushed
the
ni4-refactor-signature-subpackets
branch
from
613fd18 to
5ddd706
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ni4
force-pushed
the
ni4-refactor-signature-subpackets
branch
4 times, most recently
from
903fddf to
0df336e
Compare
ni4
force-pushed
the
ni4-refactor-signature-subpackets
branch
from
0df336e to
27b1ab7
Compare
ni4
changed the title
ni4
force-pushed
the
ni4-refactor-signature-subpackets
branch
from
27b1ab7 to
511744f
Compare
ni4
force-pushed
the
ni4-refactor-signature-subpackets
branch
from
580c3a9 to
ebcdb2e
Compare
desvxx
approved these changes
Oct 13, 2024
|
Merging with two approvals. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and get closer to absence of anonymous unions and raw pointers.