Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bunch of minor oss-fuzz/coverity issues. #2285

Merged
merged 4 commits into from
Nov 2, 2024
Merged

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Oct 23, 2024

As title says.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.67%. Comparing base (a421aa3) to head (064c77a).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
src/librepgp/stream-sig.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2285      +/-   ##
==========================================
+ Coverage   84.65%   84.67%   +0.01%     
==========================================
  Files         116      116              
  Lines       23422    23432      +10     
==========================================
+ Hits        19829    19840      +11     
+ Misses       3593     3592       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ni4
Copy link
Contributor Author

ni4 commented Nov 1, 2024

@ronaldtse @desvxx Ping for review!

@ni4
Copy link
Contributor Author

ni4 commented Nov 2, 2024

Thanks, merging with two approvals.

@ni4 ni4 merged commit 9077b2d into main Nov 2, 2024
124 checks passed
@ni4 ni4 deleted the ni4-fix-fuzz-coverity-issues branch November 2, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants