Use vector for pgp_dest_t cache #2299
Open
+73
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desvxx
force-pushed
the
desvxx-1782-refactor-pgp_dest_t
branch
3 times, most recently
from
6c6d244 to
ad98ec6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| /* allocate param */ | ||
| dst->param = calloc(1, paramsize); | ||
| if (!dst->param) { | ||
| param = calloc(1, paramsize); |
Check warning
Code scanning / CodeQL
Resource not released in destructor Warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2299 +/- ##
==========================================
- Coverage 84.88% 84.85% -0.04%
==========================================
Files 114 114
Lines 22785 22800 +15
==========================================
+ Hits 19341 19346 +5
- Misses 3444 3454 +10 ☔ View full report in Codecov by Sentry. |
desvxx
force-pushed
the
desvxx-1782-refactor-pgp_dest_t
branch
2 times, most recently
from
2c2771f to
c8f9f2a
Compare
desvxx
force-pushed
the
desvxx-1782-refactor-pgp_dest_t
branch
from
c8f9f2a to
2254d36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and some related changes regarding pgp_dest_t construction
fixes #1782