-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: better topological sorting #149
Conversation
Signed-off-by: Valery Piashchynski <[email protected]>
WalkthroughThis pull request introduces modifications to the Changes
TipsChat with CodeRabbit Bot (
|
Signed-off-by: Valery Piashchynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (2)
- edges.go (3 hunks)
- graph/toposort.go (2 hunks)
Files skipped from review due to trivial changes (1)
- edges.go
Additional comments (Suppressed): 2
graph/toposort.go (2)
3-3: The function signature for
TopologicalSort
has been changed from returning abool
to returningvoid
. Ensure that all calls to this function throughout the codebase have been updated to match the new signature. Also, verify that the removal of the boolean return value does not impact the logic of the code where this function is used.36-36: The function
TopologicalSort
no longer checks if the length ofg.topologicalOrder
is greater than or equal to the length ofg.vertices
. If this check was important for the function's correctness, consider reintroducing it.- return len(g.topologicalOrder) >= len(g.vertices)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- .github/workflows/codeql-analysis.yml (2 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/codeql-analysis.yml
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 74.97% 75.27% +0.30%
==========================================
Files 19 19
Lines 903 914 +11
==========================================
+ Hits 677 688 +11
Misses 195 195
Partials 31 31
|
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit
resolveEdges
function in theEndure
struct to provide notifications for disabled plugins post topological sorting, enhancing user awareness.TopologicalSort
function in theGraph
package to directly update thetopologicalOrder
field, improving code readability and maintainability..github/workflows/codeql-analysis.yml
file, ensuring up-to-date and regular code quality checks.