Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1741 basic field editing #248

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

feature/mx-1741 basic field editing #248

wants to merge 54 commits into from

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Feb 5, 2025 •
edited
Loading

Added

  • add color mode toggle to login screen
  • added new/remove buttons for additive rules for string fields
  • add event handlers for adding/removing additive value input cards
  • added text input field for email, string and temporal fields
  • add event handler for setting string input values

Changes

  • combine EditState.editor_fields and EditState.fields
  • update transformation logic to handle strings from additive rules

@cutoffthetop
feature/update mex-common to 0.48.0
11b8db5
@cutoffthetop
fix test and CHANGELOG
643861c
@cutoffthetop
update event handlers, re-style navbar and drop chakra
fd13397
@cutoffthetop
Merge branch 'feature/mex-common-0.48.0' into feature/mx-1768-url-par…
9e2e2ad 
…ams-2
@cutoffthetop
first draft
bae4b64
@cutoffthetop
harmonize styles and fix history
ee088a7
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ed…
0a14e1b 
…itor into feature/mx-1768-url-params-2
@cutoffthetop
fix editor entrypoint, update styles
a1410ba
@cutoffthetop
fix project.scripts
f2e0c83
@cutoffthetop
more css
5063065
@cutoffthetop
clean up, and CL
37bda15
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ed…
9ea3b21 
…itor into feature/mx-1768-url-params-2
@cutoffthetop
update along drop
8b2b4d7
@cutoffthetop
hold back push params for now
0ecaf6e
@cutoffthetop
hold back query_tuples for now
2dc6d52
@cutoffthetop
fix test locators
0a66c98
@cutoffthetop
implement search param stability
9023bbe
@cutoffthetop
update tests
9fb324d
@cutoffthetop
fix EventSpec type
d8a7fe7
@cutoffthetop cutoffthetop changed the base branch from main to feature/mx-1768-url-params-3 February 10, 2025 08:48
@cutoffthetop cutoffthetop mentioned this pull request Feb 11, 2025
Closed
1 task
Base automatically changed from feature/mx-1768-url-params-3 to main February 18, 2025 09:04
rababerladuseladim
rababerladuseladim requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boi, this is a lot. I am far from understanding everything but tried to review as best as I could.

I stumbled upon one UI issue:

  • primary source switches are sometimes not visible, e.g.: http://{editor-url}/item/27WuXh9ge9voadrk9y9t0/

mex/editor/edit/main.py Outdated
@@ -67,35 +169,82 @@ def primary_source_name(
rx.hstack(
render_value(model.name),
rx.cond(
cast(rx.vars.ArrayVar, EditState.editor_fields).contains(field_name),
~cast(rx.vars.BooleanVar, model.input_config),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a boolean? Why can you apply ~ to it? What happens here???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ is a var operation https://reflex.dev/docs/vars/var-operations/#and,-or-and-not
the casting to boolean was technically not correct, true. i changed it to ObjectVar

cutoffthetop and others added 14 commits February 27, 2025 10:49
@cutoffthetop @rababerladuseladim
Update mex/editor/edit/transform.py
0732c01 
Co-authored-by: rababerladuseladim <[email protected]>
Signed-off-by: Nicolas Drebenstedt <[email protected]>
@cutoffthetop @rababerladuseladim
Update mex/editor/edit/transform.py
fb7b706 
Co-authored-by: rababerladuseladim <[email protected]>
Signed-off-by: Nicolas Drebenstedt <[email protected]>
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ed…
aea7a08 
…itor into feature/mx-1741-basic-field-editing
@cutoffthetop
mex-common 0.53
debbf07
@cutoffthetop
Merge branch 'feature/mx-1741-basic-field-editing' of https://github.…
583982d 
…com/robert-koch-institut/mex-editor into feature/mx-1741-basic-field-editing
@cutoffthetop
cast to ObjectVar
7809893
@cutoffthetop
lock and lint
0fe4d15
@cutoffthetop
reflex 0.6
b296555
@cutoffthetop
add had_primary_source kw
dca919d
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ed…
720df36 
…itor into feature/mx-1741-basic-field-editing
@cutoffthetop
lock
7fb0571
@cutoffthetop
remove unused fixtures
cc98c4d
@cutoffthetop
more space for primary source cards
b051831
@cutoffthetop
add test
48b44ed
@cutoffthetop
Copy link
Contributor Author

I stumbled upon one UI issue: primary source switches are sometimes not visible

fixed in b051831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rababerladuseladim rababerladuseladim rababerladuseladim requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @rababerladuseladim