Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gingko Web Platform: Copy number calls stalling with FACS input. #13

Open
andrewrlynch opened this issue Nov 20, 2018 · 12 comments
Open

Comments

@andrewrlynch
Copy link

I'm analyzing a set of about 300 single cells on the Gingko web app. The karyotypes are very strange so I input a table of predicted ploidy for the cells by DAPI content. The problem is that the data processing is stalling out at certain cells. I can exclude these cells and obviously it will skip them, however it will stall out again on a different cell. Some example ploidy values that this has occurred on are 1.3, 3.4 and 3.9. Any ideas? Thanks!

@mschatz
Copy link
Collaborator

mschatz commented Nov 20, 2018 via email

@andrewrlynch
Copy link
Author

Thanks for the quick reply. Here is the link:
http://qb.cshl.edu/ginkgo?q=results/6VZust8tj6mK3la8lzxn

@jpritt
Copy link
Collaborator

jpritt commented Nov 21, 2018

Hi Andrew, I am currently working on improving Ginkgo so I took a look at your problem. It appears the facs file was responsible for stalling, as when I ran the analysis without the file it finished quickly. However I don't see your facs file in the directory - would you mind uploading it here or adding it to the project so I can take a look?

Thanks,
Jacob

@andrewrlynch
Copy link
Author

Hi Jacob,

Thanks for looking into this. I've attached the FACS file. I've also noticed that when I removed the FACS file, the analysis completes. However, the predicted ploidy from the analysis without the FACS data does not line up with the FACS data itself, so I wanted to include this in the analysis. I appreciate the assistance on this.

All the best,
Andrew

DerivedIndexPloidies_CombinedSubmitted_NormToRPE1Tri12.txt

@robertaboukhalil
Copy link
Owner

Hi all,

After running a few tests, it seems the pattern is that if the ploidy in the FACS file is < 1.5, the cell fails; otherwise, it goes through successfully.

Looking at process.R:L203, we currently look for ploidy within the range 1.5 to 6 in increments of 0.05, so if the FACS ploidy file has numbers outside the range, Ginkgo will fail.

I suppose we could parse the user ploidy file and use the numbers specified by the user instead of the fixed range.

@andrewrlynch
Copy link
Author

Hi Robert,

Thanks for looking into this. Any recommendations for next steps on my end? Also, out of curiosity, what is the utility of having the lower limit of ploidy at 1.5?

Andrew

@mschatz
Copy link
Collaborator

mschatz commented Nov 25, 2018 via email

@andrewrlynch
Copy link
Author

andrewrlynch commented Nov 30, 2018

I think the option to set a minimal ploidy would be great, or at least, in the case of attaching the FACS estimated ploidy, pulling the lowest estimated value.

Andrew

@robertaboukhalil
Copy link
Owner

Hi Andrew, sounds good, I'll take a look at adding that in and get back to you soon

robertaboukhalil added a commit that referenced this issue Dec 1, 2018
mschatz added a commit that referenced this issue Dec 3, 2018
@andrewrlynch
Copy link
Author

Hi Folks,

Thanks for working on this. Has this been deployed to the web platform? It looks like the minimum ploidy is still 1.5 and I have been having the same issues when running the data files I shared here in conjunction with the FACS-estimated ploidy values.

All the best,
Andrew

@robertaboukhalil
Copy link
Owner

cc @mschatz

@andrewrlynch
Copy link
Author

Hi @mschatz and @robertaboukhalil,

I hope this is okay. I appreciate you both putting the time in on this. I'm just curious if this has been implemented for the web app? I have flow data I would like to incorporate into my analysis, but it looks like it is still timing out on some of the files as I mentioned previously. It also looks like the minimum ploidy is 1.5. Would it be possible to lower this to 1 or lower? We have highly variable samples due to chromosome missegregation.

All the best,
Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants