Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13: FACS file parsing breaking #14

Merged
merged 3 commits into from
Dec 3, 2018
Merged

Conversation

robertaboukhalil
Copy link
Owner

@robertaboukhalil robertaboukhalil commented Dec 1, 2018

This PR is to address issue #13.

Initially, it seemed like the issue was that, given a FACS file, Ginkgo could only pick a CN multiplier within [1.5, 6], even though a cell was marked as e.g. ploidy 1.3. However, looking more closely at the code, the multiplier is correctly set by the FACS file regardless of its value.

So Ginkgo's CN calculation works fine; where it breaks is when it tries to plot the SoS error plot; this is where it assumes the CN multiplier is within [1.5, 6], so this PR updates that SoS plot such that it shows:

  • which ploidy Ginkgo would have guessed if no FACS file was provided
  • which ploidy was chosen from the FACS file (even if outside [1.5, 6])
  • the SoS error for that FACS ploidy

cc: @jpritt: I sent you an invite to become a collaborator on this repo so that I can add you as a reviewer


Sample output (with FACS file):

Sample output (without FACS file):

(hg19.T1 is the cell that currently fails in Ginkgo)

@mschatz
Copy link
Collaborator

mschatz commented Dec 3, 2018

Looks great. Thanks for working on this!

Mike

@mschatz mschatz merged commit cd7e4bc into master Dec 3, 2018
@robertaboukhalil
Copy link
Owner Author

Thanks Mike! Is this deployed to qb.cshl.edu?

@andrewrlynch
Copy link

Hi all,
Thank you all for being so responsive and working on this. I've tried running these files again with the FACS file and have been getting the same errors I described earlier. Have these changes been deployed?

Thanks again,
Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants