Fix calculation of data offset range when slicing an empty tensor #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
force-pushed
the
slice-empty-tensor
branch
from
15b7f21
to
d5f9186
Compare
If any dimension in a tensor has zero size, the data offset start and end for a slice should be zero.
robertknight
force-pushed
the
slice-empty-tensor
branch
from
d5f9186
to
7e9b243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any dimension in a tensor has zero size, the data offset start and end for a slice should be zero.
The incorrect calculation led to panics when slicing empty tensors using various methods.
TODO:
clip_dimslice_axisslice