Add TensorBase::slice_with method
#360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
force-pushed
the
tensor-slice-with
branch
from
1b9749c
to
ed18362
Compare
This is like `TensorBase::{slice, slice_mut}` but is more ergonomic to use
because the rank of the returned tensor is inferred automatically. This is
achieved via a helper `IndexCount` trait which counts the number of elements in
a tuple that have index types, as opposed to range types.
Using `slice_with` ensures at compile time that the returned view has the correct rank. Since it requires the input tensor to have a static rank to infer the outut rank, it also encourages the use of static rank tensors, which is generally good practice.
robertknight
force-pushed
the
tensor-slice-with
branch
from
ed18362
to
1ca14e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new slicing methods,
slice_withandslice_with_mutthat infer the rank of the returned views automatically at compile time. This is more ergonomic to use than the existingslicemethod and avoids the possibility of specifying the wrong dimension count, or changing the rank of the sliced type and forgetting to update the slicing operation.Eventually this may replace both
sliceandslice_dyn, but it has been added as a new API initially to allow incremental adoption downstream and also allow some iteration on the details.