Add fallible variants of TensorBase::slice_with
#365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TensorBase` type has both panicking and result-returning variants of slicing methods. To make it possible to implement both of these on top of a uniform low-level API, change the low-level APIs to all return results.
Add details about which axis was affected and the index/range that was out of bounds.
Use the new slice method that will provied a unified fallible way to slice a tensor and get back either a static or dynamic-rank view.
Promise that the `Layout` associated type is a `MutLayout`, so we don't have to add that bound everywhere that uses it.
robertknight
force-pushed
the
try-slice-with
branch
from
ff9aef1
to
f7a5523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fallible variants of the new
slice_withmethod and use it to replace usage of the oldtry_slice_*methods in rten operators.In the process the errors reported by fallible slicing methods have been improved to include more details about the problem.
These are now breaking changes since existing low-level layout methods exported by rten-tensor have been modified and so has
SliceError.