Support vector inputs in MatMul operator #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ONNX spec states that the MatMul operator is a "Matrix product that behaves like numpy.matmul". `numpy.matmul` supports vector inputs: > If the first argument is 1-D, it is promoted to a matrix by prepending a 1 > to its dimensions. After matrix multiplication the prepended 1 is removed. > If the second argument is 1-D, it is promoted to a matrix by appending a 1 > to its dimensions. After matrix multiplication the appended 1 is removed. Implement this behavior in RTen.
|
A corresponding change will also be needed for MatMulInteger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ONNX spec states that the MatMul operator is a "Matrix product that behaves like numpy.matmul". TIL that
numpy.matmulsupports vector inputs:Implement this behavior in RTen.