[Fix] Departure timer timezone conversion fix #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersions use wrong timezone offsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we need only the hours and minutes of the departure timers, the exact dates on those time objects were wrong and resulted in wrong timezone offsets being used.
eg.
1900-01-01 06:39:49+01:39:49This should fix robinostlund/homeassistant-volkswagencarnet#585
Disclaimer: I am not python developer and the results here are very crude attempts that I managed to get working after a lot of googling. The problem in the code was
.astimezone(tz=None)part really.