Skip to content

Commit

Permalink
Merge pull request #27 from bromptonista/master
Browse files Browse the repository at this point in the history
Fix typos, spelling mistakes and add info about prebuilt apk
  • Loading branch information
robinpaulson authored Sep 30, 2021
2 parents 9b63526 + e4d2298 commit 4e1cc58
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 14 deletions.
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Create local.properties file in root dir, it should be looking like that:
```
app/build/outputs/apk/app-debug.apk is your apk.

## Now available in [f-droid](https://f-droid.org/repository/browse/?fdfilter=simplert&fdid=com.viper.simplert)
A prebuilt apk can also be found under `Downloads` at the [Github releases](https://github.com/iteratec/SimpleRT/releases)
tab.

Expand All @@ -60,9 +61,9 @@ Create local.properties file in root dir, it should be looking like that:
- libresolv (usually already present in both linux and macos)
- tuntap kernel module (linux version), utun (macos version, builtin)

before build (debian based example):
before build (debian-based example):
```
sudo apt-get install build-essential pkg-config libusb-1.0-0-dev
sudo apt install build-essential pkg-config libusb-1.0-0-dev
```

Makefile is universal for all platforms, just type "make && make install" to install it in prefix /usr/local and
Expand All @@ -73,7 +74,7 @@ Create local.properties file in root dir, it should be looking like that:

Usage:

- run console util as root
- run console util as root (sudo simple-rt). The iface_up.sh file needs to be present in the application folder.
- connect your android device

First connection requires some trivial steps:
Expand Down
4 changes: 2 additions & 2 deletions simple-rt-android/app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<resources>
<string name="app_name">SimpleRT</string>
<string name="title_activity_main">MainActivity</string>
<string name="accessory_error">Seems like you device doesn\'t support Android Open Accessory protocol!</string>
<string name="tun_error">Seems like you device doesn\'t support Android VpnApi! Check out tun.ko app.</string>
<string name="accessory_error">Seems like your device doesn\'t support Android Open Accessory protocol!</string>
<string name="tun_error">Seems like your device doesn\'t support Android VpnApi! Check out tun.ko app.</string>
<string name="description_service_running">Service running</string>
</resources>
4 changes: 2 additions & 2 deletions simple-rt-android/app/src/main/res/xml/accessory_filter.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
<usb-accessory
manufacturer="Konstantin Menyaev"
model="SimpleRT"
version="1.0"/>
</resources>
version="1.1"/>
</resources>
3 changes: 1 addition & 2 deletions simple-rt-cli/src/accessory.c
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ accessory_id_t gen_new_serial_string(char *str, size_t size)
accessory_id_t id;

if ((id = acquire_accessory_id()) == 0) {
fprintf(stderr, "No free accessory id's left\n");
fprintf(stderr, "No free accessory IDs left\n");
return 0;
}

Expand Down Expand Up @@ -248,4 +248,3 @@ void run_usb_probe_thread_detached(struct libusb_device *dev)
pthread_attr_setdetachstate(&attrs, PTHREAD_CREATE_DETACHED);
pthread_create(&th, &attrs, usb_device_thread_proc, dev);
}

5 changes: 2 additions & 3 deletions simple-rt-cli/src/adk.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ accessory_t *probe_usb_device(struct libusb_device *dev,
libusb_get_device_descriptor(dev, &desc);
printf("Detected usb device with vendor id %x and product id %x does "
"not support Android Open Accessory protocol.\n",
desc.idVendor, desc.idProduct);
desc.idVendor, desc.idProduct);
ret = 0;
goto error;
}
Expand Down Expand Up @@ -282,7 +282,7 @@ accessory_t *probe_usb_device(struct libusb_device *dev,
}
}

puts("Accessory was inited successfully!");
puts("Accessory was initialized successfully!");

error:
if (ret < 0) {
Expand Down Expand Up @@ -349,4 +349,3 @@ ssize_t write_usb_packet(struct libusb_device_handle *handle, uint8_t ep,

return transferred;
}

3 changes: 1 addition & 2 deletions simple-rt-cli/src/network.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ bool start_network(void)
}

if (!iface_up(tun_name)) {
fprintf(stderr, "Unable set iface %s up\n", tun_name);
fprintf(stderr, "Unable to set interface %s up\n", tun_name);
close(tun_fd);
return false;
}
Expand Down Expand Up @@ -234,4 +234,3 @@ char *fill_serial_param(char *buf, size_t size, accessory_id_t id)

return buf;
}

0 comments on commit 4e1cc58

Please sign in to comment.