Use accessors for readonly properties #1165
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the workaround where properties that are read access
None
but write accessPluginSecurity
had to be marked writable in None.d.ts to avoid the TS error "All declarations of 'property' must have identical modifiers. (2687)".We can actually specify these in
None.d.ts
with a get accessor. When a set accessor is missing, that makes the property readonly. We specify the set accessors inPluginSecurity.d.ts
, so that when plugin types are enabled, they make it a regularly accessible property.