Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed types generator #1325

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

PepeElToro41
Copy link
Contributor

@PepeElToro41 PepeElToro41 commented Jan 14, 2025

Fixed types generator failing:

  • Added a way to rename classes in RENAME_CLASSES
  • Ignored Object in the args generator
  • Fixed EditableMesh / EditableImage types
  • Added proper ContentId type
  • Added RBXObject
  • Instance now extends RBXObject
  • Added math.map

I also added current open prs where checks failed due to the generator. This would also close these pull requests:

include/roblox.d.ts Outdated Show resolved Hide resolved
include/roblox.d.ts Outdated Show resolved Hide resolved
include/roblox.d.ts Show resolved Hide resolved
@AJSteinhauser
Copy link

Does this fix support the new(ish) method for creating blank editable images? https://create.roblox.com/docs/reference/engine/classes/AssetService#CreateEditableImage

@PepeElToro41
Copy link
Contributor Author

PepeElToro41 commented Jan 19, 2025

Does this fix support the new(ish) method for creating blank editable images? https://create.roblox.com/docs/reference/engine/classes/AssetService#CreateEditableImage

It should. CreateEditableImage would return EditableImage, as long as AssetService isnt replaced, the generator would update this, if it is replaced in the custom definitions it would need to be added manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants