Fix for OS X crash on exit: moved FontMapping* action to separate menu

Still don't know why, but including those actions in the same menu as the ANTIC font items crashed. I thought it was because I was using the same SMenu id which resulted in getting the actions added into the Antic Mode menu, but putting the Groups into the same SMenu still crashed. I thought it might be something to do with the Group ids being reused, so I changed the "a1", "a2", etc to something else, but that didn't work either. Ultimately, moving the FontMapping* stuff into its own SMenu with a different id worked. Maybe because there were multiple generic Actions in different groups that got added into the same menu? Or because they were both radio buttons?
robmcmullen · Nov 23, 2015 · 76d7998 · 76d7998
1 parent 0baccc9
commit 76d7998
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/omnimon/_omnimon_version.py b/omnimon/_omnimon_version.py
@@ -1 +1 @@
-version = "0.1.1"
+version = "0.2.0"
diff --git a/omnimon/tasks/hex_edit/task.py b/omnimon/tasks/hex_edit/task.py
@@ -132,12 +132,10 @@ def get_actions(self, location, menu_name, group_name):
                             Group(
                                 *font_mapping_actions,
                                 id="a2", separator=True),
-                            id='FontChoiceSubmenu2', separator=True, name="Antic Font Mapping"),
-                        SMenu(
                             Group(
                                 FontMappingWidthAction(),
                                 id="a3", separator=True),
-                            id='FontChoiceSubmenu2', separator=True, name="Antic Font Width"),
+                            id='FontChoiceSubmenu2a1', separator=True, name="Char Map"),
                         SMenu(
                             Group(
                                 UseColorsAction(name="Powerup Colors", colors=colors.powerup_colors()),