Minor Work Items fixes #1116
Merged
Minor Work Items fixes #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmin764
added
feature
cmin764
requested review from
mikahanninen,
bendersej,
bogdancondurache and
osrjv
cmin764
commented
Oct 24, 2023
| @@ -1109,17 +1117,15 @@ def _release_on_failure(self, attributes): | |||
| state=State.FAILED, | |||
| exception_type=Error.APPLICATION, | |||
| message=message, | |||
| _auto_release=True, | |||
| _internal_release=True, | |||
There was a problem hiding this comment.
@osrjv Like you thought, wondering if now it makes sense to just release all the non-released items as FAIL during the failed Step Run. (iterating through all the inputs and checking if there's one that wasn't released and for each applying this kind of release)
There was a problem hiding this comment.
Never mind, we decided to pull back the auto_release switch.
|
Tested locally and in Control Room with the following processes: |
cmin764
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow users to be able to reserve new inputs without being obliged to release the lastly retrieved item. This can be achieved explicitly by settingauto_release=Falsewhen calling keywords likeGet Input Work ItemandFor Each Input Work Item.A couple of other bugfixes along the way:
Slack thread
Test Task package
CR Process