-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure fps limit of 120 enforced #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left a comment about the default fps value
roboflow/roboflowpy.py
Outdated
# Pass model_id and version | ||
job_id, signed_url, expire_time = model.predict_video( | ||
args.video_file, | ||
fps=40, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we make fps
configurable and use a lower number (e.g., 5) as the default value?
higher value means more frames need to be processed. In many cases, maybe we don't need to run so many frames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added fps as argument for manual test. default is 5 in predict_video()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Description
Ensure FPS limit of 120 is consistently enforced
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Passed tests