Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure fps limit of 120 enforced #299

Merged
merged 11 commits into from
Aug 13, 2024
Merged

ensure fps limit of 120 enforced #299

merged 11 commits into from
Aug 13, 2024

Conversation

ryanjball
Copy link
Collaborator

@ryanjball ryanjball commented Jul 29, 2024

Description

Ensure FPS limit of 120 is consistently enforced

Type of change

Please delete options that are not relevant.

  • [X ] Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Passed tests

Copy link
Contributor

@PacificDou PacificDou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left a comment about the default fps value

# Pass model_id and version
job_id, signed_url, expire_time = model.predict_video(
args.video_file,
fps=40,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we make fps configurable and use a lower number (e.g., 5) as the default value?
higher value means more frames need to be processed. In many cases, maybe we don't need to run so many frames.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added fps as argument for manual test. default is 5 in predict_video()

Copy link
Contributor

@PacificDou PacificDou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ryanjball
❌ pre-commit-ci[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@ryanjball ryanjball merged commit 6b37bd9 into main Aug 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants