Added smart positioning (non overlapping labels) to VertexLabelAnnotator #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kshitijaucharmal
force-pushed
the
develop
branch
from
917bb9c
to
a2e2e37
Compare
|
Accepting this based on the videos. I sense there's a lot of reviewing to do 🙂 Would you be able to create a Colab showcasing the usage? |
LinasKo
added
the
hacktoberfest-accepted
* Alos, refactored RichLabelAnnotator so its structure matches LabelAnnotator
LinasKo
approved these changes
Nov 7, 2024
SkalskiP
requested changes
Nov 8, 2024
* Vectorized * Using forces rather than discrete steps * Move along secondary axis more
…ays for passing data
LinasKo
approved these changes
Nov 8, 2024
SkalskiP
reviewed
Nov 11, 2024
SkalskiP
reviewed
Nov 11, 2024
SkalskiP
reviewed
Nov 11, 2024
SkalskiP
reviewed
Nov 11, 2024
SkalskiP
reviewed
Nov 11, 2024
SkalskiP
reviewed
Nov 11, 2024
SkalskiP
reviewed
Nov 11, 2024
SkalskiP
requested changes
Nov 11, 2024
… to 'smart_position'
…elf.smart_position:`
LinasKo
approved these changes
Nov 12, 2024
|
I've witnessed that the new algo sometimes produces more jerky motions of the label when applied to the video. I pushed the most stable combination I could find, but there's definitely room for improvement. Merging this in! Thank you very much, @kshitijaucharmal, @SkalskiP! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved issue #1383 regarding overlapping labels in output.
Changes Done in VertexLabelAnnotator, LabelAnnotator and RichLabelAnnotator
No Extra dependencies used
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Have added an optional argument to the VertexLabelAnnotator called
use_smart_positioningwhich defaults toFalse.Enabling this prevents overlapping.
Before:
overlapping.mp4
After:
VertexLabelAnnotator:
smart.mp4
Label Annotator:
labelanno_smart.mp4
Rich Label Annotator (font: Vampire Wars):
rich_label_smart.mp4
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs
Collab Link: https://colab.research.google.com/drive/1GPHr7PpZ_eNs8Gkxx_A4w6PL5p4pJAn1?usp=sharing#scrollTo=ZHptw0Fk4lk4