-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Trunk-PlayerNG Native Plugin & Base64 to the party 📡 #919
base: master
Are you sure you want to change the base?
Conversation
umm... hi? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill drop this change tomorrow, meant to clean this up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments from someone else that's been playing around with plugins.
- You shouldn't need to add this as an internal plugin if the configuration example is recommending the "Plugins" section of the config.json.
- For the benefit of all plugins (and to simplify the flow a little), it might be easier to just add the call_json to the
Call_Data_t
struct. Then anything handling the call can just grabcall_info.call_json
as it needs it.
@@ -605,6 +605,7 @@ bool load_config(string config_file, Config &config, gr::top_block_sptr &tb, std | |||
BOOST_LOG_TRIVIAL(info) << "\n\n-------------------------------------\nPLUGINS\n-------------------------------------\n"; | |||
add_internal_plugin("openmhz_uploader", "libopenmhz_uploader.so", data); | |||
add_internal_plugin("broadcastify_uploader", "libbroadcastify_uploader.so", data); | |||
add_internal_plugin("tpng_uploader", "libtpng_uploader.so", data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not need to add this line for most plugins.
It'll get loaded later once it starts parsing the "plugins": [
section of the config.json.
int upload(Call_Data_t call_info) { | ||
|
||
std::string token = this->data.token; | ||
std::stringstream json_buffer = Call_Concluder::create_call_json_string(call_info); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having both the plugin and call_concluder do a create_call_json_string(call_info);
, how about the call json gets added to the Call_Data_t
struct?
After it's generated at the end of the call, both t-r and any other plugin can simply grab it by:
set::stringstream call_json = call_info.call_json
.
Adds Trunk-Player Next Generation as a plugin 🚀
Its time to make radio analysis easy!
This plugin makes it easy to connect Trunk Recorder with Trunk-PlayerNG an Enterprise Grade Trunking API with ACLs, notifications, User management, a filterable API, Mertics, and more...
Example Universal Config
Since Trunk-PlayerNG is ACL based you dont have to worry about multiple, the server will take what you are allowed to send it.
Preflight Checks 🛫✅
Also adds Base64.h as a lib squatter