Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frequency table variable names and logging statements. #967

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

tadscottsmith
Copy link
Contributor

Resubmitting against the master branch.

This helps clean up some of the P25 frequency table (Bandplan) information variable names and logging statements.

  1. Renames Channels to Freq_Tables to align with OP25. https://github.com/boatbod/op25/blob/883c569c040cdfade78fda245929e2e9eba6df2a/op25/gr-op25_repeater/apps/tk_p25.py#L355-L373
  2. Renames channel_id_to_string function to channel_id_to_freq_string to help clarify what is being returned.
  3. Adds a channel_to_string function that prints out the channels in the format of <XX>-<YYYY> where XX is the bandplan ID and YYYY is the channel ID.

Following this PR, I plan to add a second PR to expand and add the ability to input custom frequency tables for systems that aren't correctly sending them over the control channel.

@robotastic
Copy link
Owner

Make it so! 🖖

@robotastic robotastic merged commit f00a05e into robotastic:master Aug 7, 2024
1 check passed
@tadscottsmith tadscottsmith deleted the frequency-table-master branch August 7, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants