Enable nodelet support #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if 'timeout' in str(e): | ||
| rospy.loginfo("App Manager : disabling apps requiring capabilities [timed out looking for the capability server]") | ||
| except exceptions.NotFoundException as e: | ||
| if 'Timed out' in str(e) or "Couldn't find" in str(e): |
There was a problem hiding this comment.
We should use that different exception here. Maybe keep this as NotFoundException and then handle lines 65-67 differently (allow the usual ROS exceptions to bubble up and use a different one in https://github.com/robotics-in-concert/rocon_app_platform/blob/caps_nodelet_manager/rocon_app_manager/src/rocon_app_manager/caps_list.py#L77
There was a problem hiding this comment.
@bit-pirate will follow this up in #161.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far nodelets have been quite a headache with apps. This PR will make our lives easier by utilising the newly implemented nodelet support by the capability server.
From now on all nodelets - both app and cap nodelets - are loaded into the capability server's nodelet manager. This is done automatically by using the right parameter in the app launch file, e.g. https://github.com/yujinrobot/kobuki/blob/caps_updates/kobuki_apps/rapps/random_walker/random_walker.launch.xml#L2
This PR resolves #115 and resolves #119.
NOTE: This PR already contains the changes in PR #159. Please merge that one first.