Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug lines for calibration14 and fix temperatures timestamp #1003

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Remove debug lines for calibration14 and fix temperatures timestamp #1003

merged 1 commit into from
Jan 8, 2025

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Jan 8, 2025

This PR fixes some lines of code:

  • First of all we removed the debug lines for calibration14 in embObjMotionControl::setCalibrationParametersRaw()
  • Moreover we fix the timestamps in log for temperature errors using relative time from construction of embObjMC device
  • Finally we change yError to yWarning when failing to read temperatures considering that in that case the system won't stop

cc: @valegagge

@MSECode MSECode self-assigned this Jan 8, 2025
@MSECode MSECode requested a review from valegagge January 8, 2025 13:46
@MSECode MSECode marked this pull request as draft January 8, 2025 13:47
@pattacini pattacini linked an issue Jan 8, 2025 that may be closed by this pull request
Improve the diagnostic for temperature values and remove calib14 debug lines #1000
Closed
@pattacini

This comment was marked as resolved.

Sign in to view
@MSECode MSECode changed the base branch from devel to master January 8, 2025 13:49
@MSECode
Remove debug lines for calibration14 in embObjMotionControl::setCalib…
173f6ba 
…rationParametersRaw()

Fix tmestamp in log for temperature errors using relative time from construction of embObjMC device
Change yError to yWarning when failing to read temmperatures
@MSECode MSECode force-pushed the feature/updateDiagnosticTempAndCalib14 branch from d321219 to 173f6ba Compare January 8, 2025 13:58
@MSECode MSECode requested a review from pattacini January 8, 2025 14:00
valegagge
valegagge approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valegagge valegagge marked this pull request as ready for review January 8, 2025 14:54
@pattacini pattacini merged commit 5b2afd2 into robotology:master Jan 8, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattacini pattacini pattacini approved these changes

@valegagge valegagge valegagge approved these changes

Assignees

@MSECode MSECode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the diagnostic for temperature values and remove calib14 debug lines
3 participants
@MSECode @pattacini @valegagge