telemetryDeviceDumper: refactor variables names in order to be compatible with robot-log-visualizer #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The blocking issues in order to have the data collected via ami-iit/robot-log-visualizer#37 |
In YARP 3.4-ish release is included an important fix for logging the odometry
…_robot_name conf This refactorization exploits the hierarchy structure of YARP_telemetry in order to divide joint variables from motor variables etc
Nicogene
force-pushed
the
feat/robot-log-vizCompat
branch
from
d5b4862 to
1621106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some changes to
telemetryDeviceDumper, first of all, add theyarp_robot_nameparameter added in #162, exploits the possibility of specifying the element names (added in #161) and the hierarchical structure (added in #146) in order to create a .mat with a format compatible torobot-log-visualizerThese changes obviously breaks the user scripts for analyze the data get from the
telemetryDeviceDumper, a possibility is to add configurable names for the variables but I am afraid would be a mess.It fixes #165
cc @GiulioRomualdi