Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CMP0094 to NEW #1509

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Set CMP0094 to NEW #1509

merged 2 commits into from
Oct 30, 2023

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Oct 29, 2023

Fix #1505 .
Supersedes #1506 .

@traversaro
Copy link
Member Author

Windows build still fails with:

2023-10-29T21:58:29.6442438Z   -- Found SWIG: C:/Miniconda3/envs/test/Library/bin/swig.exe (found version "4.1.1")  
2023-10-29T21:58:29.6582916Z   -- C:/Miniconda3/envs/test/Library/share/cmake-3.27/Modules/UseSWIG.cmake
2023-10-29T21:58:35.8540595Z   -- Found Python: C:/hostedtoolcache/windows/Python/3.12.0/x64/python3.exe (found version "3.12.0") found components: Interpreter Development Development.Module Development.Embed 
2023-10-29T21:58:35.8590547Z   CMake Warning (dev) at C:/Miniconda3/envs/test/Library/share/cmake-3.27/Modules/UseSWIG.cmake:809 (message):
2023-10-29T21:58:35.8592166Z     Policy CMP0078 is not set: UseSWIG generates standard target names.  Run
2023-10-29T21:58:35.8593408Z     "cmake --help-policy CMP0078" for policy details.  Use the cmake_policy
2023-10-29T21:58:35.8594471Z     command to set the policy and suppress this warning.
2023-10-29T21:58:35.8595266Z   
2023-10-29T21:58:35.8595782Z   Call Stack (most recent call first):
2023-10-29T21:58:35.8596524Z     bindings/CMakeLists.txt:59 (swig_add_library)
2023-10-29T21:58:35.8597490Z   This warning is for project developers.  Use -Wno-dev to suppress it.
2023-10-29T21:58:35.8598348Z   
2023-10-29T21:58:35.8842480Z   CMake Warning (dev) at C:/Miniconda3/envs/test/Library/share/cmake-3.27/Modules/UseSWIG.cmake:651 (message):
2023-10-29T21:58:35.8844239Z     Policy CMP0086 is not set: UseSWIG honors SWIG_MODULE_NAME via -module
2023-10-29T21:58:35.8845613Z     flag.  Run "cmake --help-policy CMP0086" for policy details.  Use the
2023-10-29T21:58:35.8846921Z     cmake_policy command to set the policy and suppress this warning.
2023-10-29T21:58:35.8847913Z   
2023-10-29T21:58:35.8848514Z   Call Stack (most recent call first):
2023-10-29T21:58:35.8849908Z     C:/Miniconda3/envs/test/Library/share/cmake-3.27/Modules/UseSWIG.cmake:922 (SWIG_ADD_SOURCE_TO_MODULE)
2023-10-29T21:58:35.8852590Z     bindings/CMakeLists.txt:59 (swig_add_library)
2023-10-29T21:58:35.8853721Z   This warning is for project developers.  Use -Wno-dev to suppress it.
2023-10-29T21:58:35.8854737Z   
2023-10-29T21:58:35.9231781Z   Traceback (most recent call last):
2023-10-29T21:58:35.9232702Z     File "<string>", line 1, in <module>
2023-10-29T21:58:35.9233671Z   ModuleNotFoundError: No module named 'distutils'
2023-10-29T21:58:35.9303083Z   CMake Error at bindings/CMakeLists.txt:91 (install):
2023-10-29T21:58:35.9304091Z     install FILES given no DESTINATION!
2023-10-29T21:58:35.9304798Z   
2023-10-29T21:58:35.9305333Z   
2023-10-29T21:58:35.9317311Z   CMake Error at bindings/CMakeLists.txt:92 (install):
2023-10-29T21:58:35.9318431Z     install TARGETS given no LIBRARY DESTINATION for module target
2023-10-29T21:58:35.9319330Z     "_icub_python".
2023-10-29T21:58:35.9319863Z   
2023-10-29T21:58:35.9320284Z   
2023-10-29T21:58:36.0894046Z   -- Configuring incomplete, errors occurred!

However, this is probably an effect of:

  • icub-main has CMP0094 set to OLD, and GitHub Actions has a installed non-conda python installed in C:/hostedtoolcache/windows/Python/3.12.0/x64/python3.exe that CMake finds

As this will be fixed by #1508, I would merge this that improves the situation.

@traversaro traversaro merged commit 7c6c6e2 into master Oct 30, 2023
30 of 34 checks passed
@traversaro traversaro deleted the fixwincmake branch October 30, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CI Mid October 2023 - YARP compilation failure and CMake find wrong non-conda Python executable
1 participant