Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devel ergoCubSN001 #717

Merged
merged 7 commits into from
Feb 26, 2025
Merged

Devel ergoCubSN001 #717

merged 7 commits into from
Feb 26, 2025
+322 −180

Conversation

pattacini
Copy link
Member

Copy of #715.

@pattacini pattacini requested a review from S-Dafarra February 22, 2025 17:25
@pattacini pattacini self-assigned this Feb 22, 2025
@pattacini
Copy link
Member Author

pattacini commented Feb 22, 2025 •
edited
Loading

To solve the conflict I'd need to rebase devel-ergoCubSN001 on top of upstream/devel or try to figure out how to address the file with conflicts.

pattacini
pattacini commented Feb 22, 2025
View reviewed changes
Copy link
Member Author

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inline comments for @AntonioConsilvio

@S-Dafarra
Copy link
Contributor

I tried to rebase on top of devel and test the robot, but unfortunately the robot does not start because of #684.

In particular, the robot interface complains about the version of the AMCBLDC boards. At the moment I personally don't have the bandwidth to do a FW update

@pattacini
Copy link
Member Author

Uhm, does this mean that upon releasing distro 2024.11.x (that should have come after #684), ergoCubSN001 FW hasn't been updated?

This sounds even stranger to me as ergoCubSN001 has been recently under maintenance.
Let me track it down, cc'ing @AntonioConsilvio

@pattacini
Copy link
Member Author

This sounds even stranger to me as ergoCubSN001 has been recently under maintenance.
Let me track it down, cc'ing @AntonioConsilvio

Just got aligned with @AntonioConsilvio
Even though the robot was under maintenance, we didn't have time to update the FW because it was required to deliver it asap for a demo.

@pattacini
Copy link
Member Author

@GiulioRomualdi is going to update the FW.

@S-Dafarra S-Dafarra mentioned this pull request Feb 26, 2025
Closed
@S-Dafarra
Copy link
Contributor

The branch has been rebased on top of devel and applied the fix of icub-tech-iit#4

@pattacini pattacini merged commit dc9da84 into robotology:devel Feb 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Dafarra S-Dafarra S-Dafarra approved these changes

Assignees

@pattacini pattacini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pattacini @S-Dafarra @GiulioRomualdi @AntonioConsilvio @isorrentino @traversaro