Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tableviewer app #13

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Implement tableviewer app #13

wants to merge 22 commits into from

Conversation

virtuald
Copy link
Member

@virtuald virtuald commented Apr 25, 2016

I'm creating this pull request for you so I can comment on things. :)

Fixes #10


function Tableviewer($el) {
this.$el = $el.addClass('tableviewer');
this.ntRoot = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you trying to use this as a map? What about NT keys with weird symbols in them? That's why I use the d3_map in the main NT websocket class...

@virtuald
Copy link
Member Author

@amorygalili this PR

@virtuald
Copy link
Member Author

Other issues:

  • Don't auto-expand the tree
    • Maybe store the last tree state in a cookie?
  • Sort keys automatically
  • Weirdness with adjusting the width of the page
  • Firefox compatibility

Base automatically changed from master to main January 14, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants