Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to Multi-Stage #175

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

multi-stager
Copy link
Contributor

Hi,

Thanks for maintaining mudslide. I represent a research group investigating multi-stage builds. We recently refactored your Dockerfile to a multi-stage Dockerfile and found that it brings the following benefits:

✅ Reduced final image size (from 1079MB to 447MB)
✅ Minimized image vulnerabilities (verified via Trivy, from 202 to 105)

We hope this small improvement to the Dockerfile will be useful to you :)

Thanks,

@robvanderleek
Copy link
Owner

Hi 👋

Thanks for the contribution, this is a nice improvement.

I needed to move one of the environment variables from the build stage to the runtime stage in order to prevent behavior regression.
Also, I removed the comments and named the second stage "runtime" (but this is just a personal preference.)

Do you have a bit more background on your research group? The multi-stager account looks very anonymous.

KR, Rob

@multi-stager
Copy link
Contributor Author

@robvanderleek Hi Rob,

I'm glad to hear that you found our contribution valuable.

The reason for using an anonymous account for our PR is the double-blind restrictions in the submission process of conferences. We look forward to sharing more details once the anonymity period is over.

Thank you once again for your feedback. :)

Best regards,

@robvanderleek robvanderleek merged commit cf326d4 into robvanderleek:main Feb 7, 2025
2 checks passed
@robvanderleek
Copy link
Owner

The reason for using an anonymous account for our PR is the double-blind restrictions in the submission process of conferences. We look forward to sharing more details once the anonymity period is over.

I see. PRs from an anonymous account are treated with a lot of suspicion by maintainers, be aware.

I've merged the PR, thanks again and good luck with the research 👍

@multi-stager
Copy link
Contributor Author

I see. PRs from an anonymous account are treated with a lot of suspicion by maintainers, be aware.

I've merged the PR, thanks again and good luck with the research 👍

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants