Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn abilities tests for wasm dev and wasm LLVM back on #3735

Merged
merged 5 commits into from
Aug 14, 2022

Conversation

ayazhafiz
Copy link
Member

@ayazhafiz ayazhafiz commented Aug 9, 2022

Closes #3708
Closes #3709

@folkertdev
Copy link
Contributor

looks like this is now a miscompilation for llvm wasm only. I'll have a look

@folkertdev
Copy link
Contributor

@Anton-4 I tried using the feature flag that does not require bindgen to be installed, but that still runs into libclang problems. Bindgen uses clang-sys, which has some environment variables that can be tweaked. in particular, https://crates.io/crates/clang-sys has

CLANG_PATH (runtime) - provides a path to a clang executable

maybe we can use that? I'll just go back to using the bindgen executable here for now, but I would like to get rid of that at some point.

@folkertdev
Copy link
Contributor

you might even be able to point that to zig cc

@Anton-4
Copy link
Collaborator

Anton-4 commented Aug 13, 2022

@folkertdev I've made issue #3783 for this and planned it in for next week.

@folkertdev folkertdev merged commit f2a6310 into main Aug 14, 2022
@folkertdev folkertdev deleted the turn-on-abilities-wasm-tests branch August 14, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate OOB access in wasm backend Investigate wasm3 stack overflow during function compilation
3 participants