Handle parse error for bad head exposes list #7408
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7246
It improves the parse error message if you have an invalid exposes list in the module header. The new error is:
To do this, I had to add a branch to handle
EExposes::ListStart
in the functionto_exposes_report
.I originally wanted to add more context to this error message based on whether the header in question was an
app
or amodule
. However, that would've required adding additional metadata toEHeader
, which seemed out of scope.While there, I noticed the branches for
EExposes::Identified
andEExposes::ListEnd
are the same with a TODO to split them up, so I looked into that as well. As it turns out, that would require tweaking parsing which seems out of scope, so I updated the TODO with more context and left it as is.