#7407: Register package dependent packages #7412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cargo test and clippy pass locally |
gamebox
requested review from
rtfeldman,
agu-z,
lukewilliamboswell,
bhansconnect,
Anton-4 and
smores56
|
Have you tested this with real packages? |
smores56
reviewed
Dec 25, 2024
|
Depends on what you mean by a real package. I built my own packages and had them depend on others. Do you have examples I should check out? |
|
No, that works. I just meant packages instead of a Rust test, which wasn't added. I think if you got this working with your own packages, that gives me confidence that it'll work. |
|
How would I go about adding a test for this? And where would it live? load_internal? Work? |
|
Added a unit test for you @smores56 |
ayazhafiz
reviewed
Dec 26, 2024
Comment on lines
+1320
to
+1323
| let use_main = match header_type { | ||
| Package { .. } | App { .. } | Platform { .. } => true, | ||
| Module { .. } | Builtin { .. } | Hosted { .. } => false, | ||
| }; |
There was a problem hiding this comment.
maybe localize to the usage site
There was a problem hiding this comment.
Couldn't find a way due to borrow issue without introducing clones
ayazhafiz
previously approved these changes
Dec 26, 2024
smores56
reviewed
Dec 26, 2024
smores56
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A package that depended on another package would hang forever because nothing registered the other package as a module to load like it would with an App. This fixes that.
Closes #7407