Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update homepage and tutorial #7544

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Update homepage and tutorial #7544

wants to merge 10 commits into from
+661 −535

Conversation

gamebox
Copy link
Collaborator

@gamebox gamebox commented Jan 23, 2025 •
edited
Loading

For the next release

image

@rtfeldman
Copy link
Contributor

@gamebox probably already on your radar, but I noticed the examples at the bottom of the screenshot are still using syntax highlighting for !, camelCase, and not saying main! = or handle_req! =

Anton-4
Anton-4 reviewed Jan 24, 2025
View reviewed changes
www/content/tutorial.md Outdated Show resolved Hide resolved
@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 24, 2025

Major effort, thanks @gamebox :)

smores56
smores56 requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@smores56 smores56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through and marked everything I found. If all of these get fixed, we should be good to merge, unless you've got other content-based adjustments to make

www/content/index.md Outdated Show resolved Hide resolved
www/content/index.md Outdated Show resolved Hide resolved
www/content/tutorial.md Show resolved Hide resolved
www/content/tutorial.md Show resolved Hide resolved
www/content/tutorial.md Show resolved Hide resolved
www/content/tutorial.md Outdated Show resolved Hide resolved
www/content/tutorial.md Outdated Show resolved Hide resolved
www/content/tutorial.md Outdated Show resolved Hide resolved
www/InteractiveExample.roc Outdated Show resolved Hide resolved
www/InteractiveExample.roc Outdated Show resolved Hide resolved
smores56
smores56 reviewed Jan 24, 2025
View reviewed changes
www/build-dev-local.sh Outdated Show resolved Hide resolved
@gamebox gamebox marked this pull request as ready for review January 24, 2025 19:02
smores56
smores56 reviewed Jan 24, 2025
View reviewed changes
www/content/tutorial.md Outdated Show resolved Hide resolved
www/content/tutorial.md Show resolved Hide resolved
smores56
smores56 previously approved these changes Jan 24, 2025
View reviewed changes
smores56
smores56 previously approved these changes Jan 24, 2025
View reviewed changes
@lukewilliamboswell
Copy link
Collaborator

@gamebox we can upgrade to use https://github.com/lukewilliamboswell/basic-ssg/releases/tag/0.9.0 in this PR

@gamebox
Copy link
Collaborator Author

gamebox commented Jan 25, 2025

Upgraded

smores56
smores56 previously approved these changes Jan 25, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-4 Anton-4 Anton-4 left review comments

@smores56 smores56 smores56 left review comments

@rtfeldman rtfeldman Awaiting requested review from rtfeldman

@lukewilliamboswell lukewilliamboswell Awaiting requested review from lukewilliamboswell

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gamebox @rtfeldman @Anton-4 @lukewilliamboswell @smores56