-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(roc-plugin-repo): Add semver utilities tests #12
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, good just one small change! 👍
.travis.yml
Outdated
@@ -5,4 +5,5 @@ cache: | |||
node_js: | |||
- 6.9 | |||
before_script: | |||
- git fetch --unshallow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not need this anymore after 21997dd was merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may still need it just for tests, the change was done in generateStatus.js
and tests don't touch that file, so that path remains broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, maybe it's still needed here then and given that the tests seems to fail now it kinda points to that.
86b5b55
to
e748478
Compare
9aa26cb
to
872a53c
Compare
86c5cf8
to
4a61efd
Compare
Just a beginning of what could eventually become extensions-wide tests. Started with semver utils because they seemed to fit the time scope of the hackday.