Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove arguments from the path to check file existence #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

annaborn
Copy link

@annaborn annaborn commented Nov 4, 2021

No description provided.

@annaborn
Copy link
Author

annaborn commented Nov 4, 2021

@maltewi
Hello Malte! Could you please check this commit? :)

@maltewi
Copy link
Member

maltewi commented Nov 4, 2021

can you briefly describe what the problem of the current implementation or the not-covered use case is, that the patch now implements/fixes?

@annaborn
Copy link
Author

annaborn commented Nov 4, 2021

the problem occurres, if the file path contains argument (e.g. if we want to call some script with arguments)

i am not sure, if I have to add similar check to other findFileByName functions

@maltewi
Copy link
Member

maltewi commented Nov 5, 2021

I still don't understand what you mean. What is a file path with arguments? Can you give an example?

@annaborn
Copy link
Author

annaborn commented Nov 5, 2021

Due to the check by findFileByName, we got an error in xec program. In xec programm we call ruby script and pass the argument --head with it.
Initially the findFileByName checks the existing of ruby file, but by checking it does not cut off the argument (--head). So it leads to the error.

ERROR: Error during compilation: Could not resolve template $BUNDLE_ROOT/scripts/controllers/start_ndlcom_drivers.rb --head: Could not find file scripts/controllers/start_ndlcom_drivers.rb --head

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants