Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First rought version of ply-exporter #28

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

goldhoorn
Copy link
Collaborator

No description provided.

@malter
Copy link
Member

malter commented Feb 11, 2015

Could you please remove the warning and if hack_aperture is not a good variable name in the mainstream you can change it to aperture_file?

@goldhoorn
Copy link
Collaborator Author

Is this really needed or could the whole "hack "block removed?

On 11.02.2015 09:22, malter wrote:

Could you please remove the warning and if hack_aperture is not a good
variable name in the mainstream you can change it to aperture_file?


Reply to this email directly or view it on GitHub
#28 (comment).

Dipl.-Inf. Matthias Goldhoorn
Space and Underwater Robotic

Universität Bremen
FB 3 - Mathematik und Informatik
AG Robotik
Robert-Hooke-Straße 1
28359 Bremen, Germany

Zentrale: +49 421 178 45-6611

Besuchsadresse der Nebengeschäftstelle:
Robert-Hooke-Straße 5
28359 Bremen, Germany

Tel.: +49 421 178 45-4193
Empfang: +49 421 178 45-6600
Fax: +49 421 178 45-4150
E-Mail: [email protected]

Weitere Informationen: http://www.informatik.uni-bremen.de/robotik

@goldhoorn
Copy link
Collaborator Author

updated

@goldhoorn
Copy link
Collaborator Author

@malter pong

@goldhoorn
Copy link
Collaborator Author

@malter : do you accept this or do i need to change something??

@malter
Copy link
Member

malter commented Mar 24, 2015

It would be better if the depth texture is only created when it is used the first time?

@goldhoorn
Copy link
Collaborator Author

don't know then there might be a delay (e.G. the first frame might not have been captured?!)

@malter
Copy link
Member

malter commented Aug 6, 2015

Maybe, if you want to use the ply export you have to initialize the use of the depth buffer by calling the function once at the beginning or we add a initDepthBuffer to the GraphicsManagerInterface. But still it would be better to render the depth buffer only to texture if required.
You could also add it as configuration.

@goldhoorn
Copy link
Collaborator Author

updated

@malter
Copy link
Member

malter commented Aug 17, 2015

did you pushed your changes?

@goldhoorn
Copy link
Collaborator Author

Yep, but to the wrong branch ;), now this one

@goldhoorn
Copy link
Collaborator Author

pong

@goldhoorn
Copy link
Collaborator Author

@malter dupdidu

@goldhoorn
Copy link
Collaborator Author

@malter : pong?

@goldhoorn
Copy link
Collaborator Author

@malter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants