Issue #113 Logitech Media Server RockOn update for Rockstor

[Hooverdan96]

Fixes #238
Added new LogitechSqueezebox-7.9.4.json to RockOn repository
Using new docker image that also supports arm architecture
Update to root.json to reflect RockOn addition

General information on project

This pull request proposes to add a new rock-on for the following project:

• name: Logitech Media Server (aka Squeezebox, slimserver) updated version
• website: https://mysqueezebox.com/index/Home
• description: this RockOn represents a new multi-architecture version for the Logitech Media Server, based on version 7.9.4

Information on docker image

• docker image: https://hub.docker.com/r/doliana/logitech-media-server
• is an official docker image available for this project?: No. This one is periodically auto-build with new updates and supports ARM architecture

Checklist

• Passes JSONlint validation
• Entry added to root.json in alphabetical order (for new rock-on only)
• "description" object lists and links to the docker image used
• "description" object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)
• "website" object links to project's main website

[Hooverdan96]

Linked to Issue: #113

[phillxnet]

@Hooverdan96 This is great stuff, thanks. We should be able to begin working on the Rock-ons and Docs backlog shortly. Just getting our systems lined up ready to ease testing prs in both these repos, so not long now.

[Hooverdan96]

My apologies for pushing two more updates so quickly (I know you prefer a single push to review considering all the other stuff you're reviewing) ... after building another VM with the latest OpenSUSE release of Rockstor, I realized that my originally pushed version here contained an "older" version of the json file I had tested. I also recognized that this image does not support passing in a UID or PGID, so I made adjustments accordingly (highlighting in the tooltip that the config share needs r/w for UID=1000.
Finally, I restructured the description a bit for readability and added an icon link, too.

[FroggyFlox]

Hi @Hooverdan96 ,

I just had a look at your PR and it seems good! I only one problem with it, but that is completely independent from you: the use of host networking.
As evidenced in a recent PR (#227 (comment)), this can create conflicts with the UI port when another rock-on is already set on using that same port (even without being installed). We've created an issue to keep track of it and solve the issue (rockstor/rockstor-core#2209), but in the meantime, we may want to specify in the UI port description that one needs to use 9000 (and not something else) in order for the UI button to work. You can use the linked Jellyfin rock-on for an example if you'd like. Maybe we could also mention it in the "more_info" field?

[FroggyFlox]

@Hooverdan96 , I just realized I forgot to ask you the most important question:
Is host networking required in this rock-on? I suspect it is, but I just wanted to make sure.

[Hooverdan96]

@FroggyFlox, ah, yes, it unfortunately seems that way (similar to the Plex one). I tried to run it without but then I don't get the apple products to connect, while if I have net=host set, this seems to work.
I can add the reference to the more_info button, if that works for you.

Semi-unrelated .. and I can open a separate topic on this, the "more-info" is not really available until after the installation, can it be possible to have it visible before? Like in the jellyfin instance, if it's only available in the more info, it will be hard for a user to find out why a subsequent Docker install is not working. Or ... in the error message that you post after a failed install (go look in the logs), maybe one could add a reference to check out existing/installed rockons and possible port conflicts?
Sorry, just wanted to make a short remark on this, and now it's an entire paragraph.

[FroggyFlox]

@FroggyFlox, ah, yes, it unfortunately seems that way (similar to the Plex one). I tried to run it without but then I don't get the apple products to connect, while if I have net=host set, this seems to work.

That makes sense, thanks for verifying that one out.

I can add the reference to the more_info button, if that works for you.

Sounds good! Could you also mention it in the UI port description, by any chance? The Jellyfin rock-on, for instance, will have it as:

"description": "Jellyfin WebUI port. This MUST be 8096 due to current networking limitations",

Semi-unrelated .. and I can open a separate topic on this, the "more-info" is not really available until after the installation, can it be possible to have it visible before? Like in the jellyfin instance, if it's only available in the more info, it will be hard for a user to find out why a subsequent Docker install is not working. Or ... in the error message that you post after a failed install (go look in the logs), maybe one could add a reference to check out existing/installed rockons and possible port conflicts?

That sounds like a good idea, indeed... Personally, I'm always concerned about cluttering, but that is far from it so it should be fine. It definitely is worth a try, at least, and see how it goes. I would thus say go for it and open a dedicated issue on the rockstor-core repo (as this is where changes would be required) linking to this issue and we can brainstorm on the best way to do it.

[Hooverdan96]

@FroggyFlox: I updated the WebUI portion with the corresponding comment. I decided then not to add the "More_Info" tag, since for this RockOn there wasn't one before. Hope, that's ok.
As I experiment with the LMS RockOn in the future, I will eventually propose the 8.x version as well and maybe I can also then figure out how to get around the net=host conundrum (maybe Linxuserver will eventually put one out, but who knows).

[FroggyFlox]

Sounds good, @Hooverdan96 ! If at any point you feel like the "More info" field could be beneficial for a rock-on (any rock-on) that doesn't have it, feel free to add it.

I'll try to spend some time today making some actual progress in our current rock-on backlog. Thanks a lot for all your contributions, that's incredibly helpful!

[FroggyFlox]

@Hooverdan96 ,

It all works well on my end! I just realized what you meant earlier with regards to the "More info" field; I misunderstood earlier, so my apologies for an erroneous answer at the time. I do believe we should mention the port requirement in the "More info" field in case the user would miss the info/tooltip during the install wizard. I thus added a suggestion accordingly.

Let me know what you think of it.

[Hooverdan96]

@FroggyFlox: I accepted your suggestion. Makes sense to me, and since the More_info is "out of the way" is doesn't add to the clutter you were concerned about.

[Hooverdan96]

yep, didn't see the typo piece, thanks for noticing.

[FroggyFlox]

@Hooverdan96 , nice submission! It all works as intended so I'm going to merge it now.

Thanks again for yet another nice rock-on!