-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document resetting Rock-on Root (#434) #503
Document resetting Rock-on Root (#434) #503
Conversation
Update overview.rst to include Rock-on root reset
@Hooverdan96 Re:
This also requires that this branch be re-based. But not required as we know the failure now. And I have now merged that PR. So we are hopefully getting ahead of the little thorn. About to review this now so no need to re-base by the way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hooverdan96 Thanks for yet-another great addition.
I'm a bit concerned about folks jumping to this brute-force solution: but there are warnings in there. But this is rather the nuclear option in my opinion. But as you indicated here, it can be necessary on occasions. So it can only be good to have it documented as you've presented. Thanks.
See what you think of my suggested changes, almost all trivial actually; but hopefully also nice-to-have.
My main indicator that this this procedure is necessary has been log entries to the effect that a subvol/snapshot was was missing pertaining to a docker container. What we likely need in rockstor-core here is more use of:
docker system prune -a --volumes
And maybe that could be added to this doc as a pre-nuclear (wipe / recreate) option. And only if that, once run, followed by a Pool refresh to update subvols fails to work do we then suggest this rather radical option of switching/refreshing the Rock-ons root share.
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Thanks for the suggestions, I've accepted them. I will incorporate your additional comments from above and bring these back (and address the current Sphinx failure that now seems to have popped up). |
@Hooverdan96 Thanks. Let me know when I should re-test and publish:
Yes, that one was down to me I'm afraid. I failed to also modify the number of chars indicating a sub-header to match the sub-header changes I made. My apologies for the extra work there. |
provide additional resolution path and add warning for resetting Rock-ons root.
@phillxnet, I did end up rebasing the branch, and rearranged the nuclear option to be after a section on pruning, and also updated the logs symptom with your comment about missing subvols. |
The linkcheck failures this time around where related to
|
@Hooverdan96 Thanks for including that extra command, may end-up saving some folks from having to do the more extensive reset procedure. I'll merge and get this published. As always much appreciated. It's great to have this procedure finally documented. In time we can automate better a Rock-on reset, or have Web-UI intergration for force uninstall and the like; but bit-by-bit. |
Re the smartmontools linkcheck hick-up, a couple of builds locally did not show this failure. So as you surmised I think we caught them on a bad day. Or they don't like GitHub actions accessing their site. |
PR product PRODUCTION published. |
Fixes #434 .
This pull request's proposal (superseeding PR #502).
add the Rock-on root reset process to the section that deals with uninstalling/installing Rock-ons. Also, some minor cleanups in the same file.
Checklist
Note: Linkcheck will continue to fail until a currently open PR has been merged.