Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update password reset Documentation (#404) #505

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

Hooverdan96
Copy link
Member

Fixes #404

This pull request's proposal

move old password reset procedure to legacy, update existing page with V4 version, as it's also a hard-coded link to the login screen on the Rockstor WebUI.

Checklist

  • With the proposed changes no Sphinx errors or warnings are generated.
  • I have added my name to the AUTHORS file, if required (descending alphabetical order).

Note: Link check will continue to fail until currently open PR addressing this is merged.

update toctree for legacy pwd reset
new screenshots
set up legacy reset vs. new
Copy link
Member

@phillxnet phillxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hooverdan96 Thanks again for yet another update.

This is, as usual, very nice. I've just got a couple of formatting issues that I think, but I'm not certain, are caused by a formatting hang-over. I.e. prior line ending in " ::" clashing with an otherwise defined console block format. Hence my suggestions re using a regular ":" to end the preceding user-visible text as we are introducing that which was promised. And we now have the working earlier in the same new doc .. code-block:: console.

I can easily re-test the formatting, post you applying the suggested change at your end, if you have little time to confirm my suspicion regarding these end-format fails.

howtos/reset-root-password.rst Outdated Show resolved Hide resolved
howtos/reset-root-password.rst Outdated Show resolved Hide resolved
@Hooverdan96
Copy link
Member Author

Hooverdan96 commented Oct 25, 2024

yes, I think you were right on that. I had fixed some further up before pushing, but I apparently missed a couple (the black background and somewhat "dim" font color contrast is throwing me off still probably).

@phillxnet
Copy link
Member

@Hooverdan96 Thanks, and yes that does look to have fixed those console block issues:

console-block-format-fixed

Cheers. I'll merge and get this published then.

@phillxnet phillxnet merged commit 2d33db1 into rockstor:master Oct 25, 2024
3 checks passed
@phillxnet
Copy link
Member

PR product PRODUCTION published.

@Hooverdan96 Hooverdan96 deleted the 404_res_pwd_new branch October 25, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update/replace root password reset doc to v4+ "Built on openSUSE"
2 participants