Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tidy re use of 'openSUSE' #509 #510

Merged

Conversation

phillxnet
Copy link
Member

@phillxnet phillxnet commented Oct 30, 2024

Fixes #509

This pull request's proposal

Light edit re semantic linefeeds, and use of the Trademark 'openSUSE'. Specifically in the newly altered v3 to newer major versions migration doc.

#Includes

  • Additional overview (sub-title and note) re v4 no longer auto-importing the system disk.
  • Minor rewording.

Checklist

  • With the proposed changes no Sphinx errors or warnings are generated.
  • I have added my name to the AUTHORS file, if required (descending alphabetical order).

Light edit re semantic linefeeds, and use of the Trademark 'openSUSE'.
Specifically in the newly altered v3 to newer major versions migration
doc.

#Includes
- Additional overview (sub-title and note) re v4 no longer auto-importing
the system disk.
- Minor rewording.
@phillxnet
Copy link
Member Author

@FroggyFlox & @Hooverdan96 I'm going to merge this and publish as I'm keen to have this issue resolved. And to have a newer example of my take on semantic linefeeds.

Mainly here I've added a bit about our non-auto import of the system pool as that has come up on the forum as a surprise to some doing this migration: and I've noted the version this default changed.

We have yet-another failed links here in GitHub tasks but this was not observed in local linkcheck testing.

@phillxnet phillxnet merged commit 9ef114e into rockstor:master Oct 30, 2024
2 of 3 checks passed
@phillxnet phillxnet deleted the 509-Minor-tidy-re-use-of-'openSUSE' branch October 30, 2024 15:41
@phillxnet
Copy link
Member Author

We still have quite a lot of redundancy in this file, but it is still fairly short and relatively clear so leaving for the time being. Much improved by @Hooverdan96 recent changes and I just wanted to do a minor edit re the already mentioned elements introduced here. Specifically we must take care when using "openSUSE" in our docs as we are "Built on openSUSE" or "Uses openSUSE" as per our choices from the referenced doc. I added in this PR another reference to the canonical doc re our guidelines on this mark use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor tidy re use of 'openSUSE'
1 participant